Fix various minor bugs in vulnerability policy evaluation #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix various minor bugs in vulnerability policy evaluation:
repeated
and non-emptyVulnerabilityAlias
es to policy Protobufs failed because alias objects were not detached from the persistence contextVulnerabilityAlias
es did not end up getting passed to the policy evaluator, which in case a policy tried to access aliases triggered, necessitated a database query to load them prior to evaluationI also refactored
VulnerabilityScanResultProcessorTest
to use an actualVulnerabilityPolicyEvaluator
instead of a mocked one. Mocking it made it impossible to test the end-to-end process properly.Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly